[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] slc: Fix return type
From:       Christian Costa <titan.costa () gmail ! com>
Date:       2013-05-31 15:45:13
Message-ID: CAMo6X8bN8bZHfn64XSq8pt0PGSJUL1g+77reV6r_UGjeVXPHhQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


2013/5/31 Detlef Riekenberg <wine.dev@web.de>

> Christian wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr
>
> > > + */
> > > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD
> *pvalue)
> > > +{
> > >
> > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR
> lpszValueName, LPDWORD pdwValue);
> > > +SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *);
> > >
> > I think s/PCWSTR/const WCHAR */ and s/pvalue/value/ would be better. :)
>
> I disagree for "const WCHAR *", which is really rare used in Wine
> (Please grep the headers yourself)
>
>
There was a discussion about the LPxxx stuff removal (I guess Pxxx as well)
some time ago.
There was also something about const that doesn't behave as expected in
that case but I don't remember the details.


> pvalue is a matter of taste.
>

It's not particularily my taste. It's something preferred. It was just a
guess since the patch was pending.

Christian

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2013/5/31 Detlef \
Riekenberg <span dir="ltr">&lt;<a href="mailto:wine.dev@web.de" \
target="_blank">wine.dev@web.de</a>&gt;</span><br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Christian \
wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr<br> <div class="im"><br>
&gt; &gt; + */<br>
&gt; &gt; +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD \
*pvalue)<br> &gt; &gt; +{<br>
&gt; &gt;<br>
</div><div class="im">&gt; &gt; -SLCAPI DWORD WINAPI \
SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue);<br> &gt; &gt; \
+SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *);<br> &gt; \
&gt;<br> </div><div class="im">&gt; I think s/PCWSTR/const WCHAR */ and \
s/pvalue/value/ would be better. :)<br> <br>
</div>I disagree for &quot;const WCHAR *&quot;, which is really rare used in Wine<br>
(Please grep the headers yourself)<br>
<br></blockquote><div> </div><div>There was a discussion about the LPxxx stuff \
removal (I guess Pxxx as well) some time ago.<br></div><div>There was also something \
about const that doesn&#39;t behave as expected in that case but I don&#39;t remember \
the details.<br> </div><div>  <br></div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> pvalue is a \
matter of taste.<br></blockquote><div><br></div><div>It&#39;s not particularily my \
taste. It&#39;s something preferred. It was just a guess since the patch was \
pending.<br></div></div><br></div><div class="gmail_extra"> Christian<br></div></div>





[prev in list] [next in list] [prev in thread] [next in thread]