[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Christian Costa : d3dx9_36: Implement skin mesh loading.
From:       Christian Costa <titan.costa () gmail ! com>
Date:       2013-05-29 11:03:19
Message-ID: CAMo6X8ZrBEbdiFOrZ+WfAwboyUKeXQSi-j-r+GqgzcGvr0hJSg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

You're right. This can be simplified. Will send a patch. Thanks.

Christian

2013/5/29 gurketsky <gurketsky@googlemail.com>

> Hi,
>
> just saw that a bit late. Is there a reason for the rewrite of hr?
>
> Could any call return anything other than D3D_OK and succeed (maybe
> S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both
> cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to
> overwrite the result anyway to D3D_OK on success, so I see no reason to
> change the hr to D3D_OK in parse_skin_mesh_info.
>
> Cheers
> Rico
>
>
> On 28.05.2013 22:16, Alexandre Julliard wrote:
>
>> +        if (SUCCEEDED(hr))
>> +            hr = mesh_data->skin_info->lpVtbl->**
>> SetBoneOffsetMatrix(mesh_data-**>skin_info, index,
>> +                     (const D3DMATRIX*)(data + nb_influences *
>> (sizeof(DWORD) + sizeof(FLOAT))));
>> +        if (FAILED(hr))
>> +            goto end;
>> +    }
>> +
>> +    hr = D3D_OK;
>>
>
>

[Attachment #5 (text/html)]

<div dir="ltr"><br><div class="gmail_extra">Hi,<br><br></div><div \
class="gmail_extra">You&#39;re right. This can be simplified. Will send a patch. \
Thanks.<br><br></div><div class="gmail_extra">Christian<br></div><div \
class="gmail_extra"> <br><div class="gmail_quote">2013/5/29 gurketsky <span \
dir="ltr">&lt;<a href="mailto:gurketsky@googlemail.com" \
target="_blank">gurketsky@googlemail.com</a>&gt;</span><br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi,<br>
<br>
just saw that a bit late. Is there a reason for the rewrite of hr?<br>
<br>
Could any call return anything other than D3D_OK and succeed (maybe S_FALSE)? It may \
be possible to drop &quot;if (FAILED(hr)) goto end;&quot; (for both cases) and \
&quot;hr = D3D_OK&quot;... Also the function (parse_mesh) seems to overwrite the \
result anyway to D3D_OK on success, so I see no reason to change the hr to D3D_OK in \
parse_skin_mesh_info.<br>

<br>
Cheers<br>
Rico<div class="HOEnZb"><div class="h5"><br>
<br>
On 28.05.2013 22:16, Alexandre Julliard wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> +        if (SUCCEEDED(hr))<br>
+            hr = mesh_data-&gt;skin_info-&gt;lpVtbl-&gt;<u></u>SetBoneOffsetMatrix(mesh_data-<u></u>&gt;skin_info, \
index,<br> +                     (const D3DMATRIX*)(data + nb_influences * \
(sizeof(DWORD) + sizeof(FLOAT))));<br> +        if (FAILED(hr))<br>
+            goto end;<br>
+    }<br>
+<br>
+    hr = D3D_OK;<br>
</blockquote>
<br>
</div></div></blockquote></div><br></div></div>





[prev in list] [next in list] [prev in thread] [next in thread]