[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: wined3d: Properly handle WS_VISIBLE and WS_EX_TOPMOST style flags on fullscreen windows.
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2013-03-31 9:08:16
Message-ID: CAOsNvwyF=5m5TGc0SAeJtdPTXZXNBU4Ykc40dYUheOJNQ-OoYw () mail ! gmail ! com
[Download RAW message or body]

On 30 March 2013 23:50, Sam Edwards <cfsworks@gmail.com> wrote:
> I'm a bit confused, then: Without this change, the exstyle test breaks, and the \
> guidelines request that every patch be atomic. They also request that all tests be \
> included in the same patch.

I'm not sure there really is such a rule.

> Off the top of my head, I would guess it's one of these:
> 1. The "all tests in the same patch" rule is only appropriate for single-patch \
> submissions, so in multipatch patchsets, it's acceptable to include a final patch \
> with nothing but tests. 2. Only introduce the tests in the last patch of the \
> patchset. (That is, add them all at once, but only when all of the necessary \
> changes have been made to allow the tests to work first.) 3. Include each test in \
> the first patch that will allow the test to pass. (That is, add them \
> incrementally.) 4. Add the tests as todo_wine in the first patch, then remove the \
> todo_wine in later patches as each test becomes functional. (That is, add them all \
> at once as todo_wine, and mark them as non-todo incrementally.)

I think either or those is fine in principle, it depends a bit on the
kind of test what's most practical. I guess that for this one you'll
probably want 3.


[prev in list] [next in list] [prev in thread] [next in thread]