[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: gdi32: Copy gamma ramp validation from winex11 to make it driver independent (try 2)
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2013-03-28 18:32:08
Message-ID: 87d2uj8jfb.fsf () wine ! dyndns ! org
[Download RAW message or body]

André Hentschel <nerv@dawncrow.de> writes:

> +    /* the bias could be because the app wanted something like a "red shift"
> +    * like when you're hit in Quake, but XVidMode doesn't support it,
> +    * so we have to reject a significant bias */

Clearly gdi32 doesn't care about XVidMode.

> @@ -1325,6 +1405,18 @@ BOOL WINAPI SetDeviceGammaRamp(HDC hDC, LPVOID ptr)
>          if (GetObjectType( hDC ) != OBJ_MEMDC)
>          {
>              PHYSDEV physdev = GET_DC_PHYSDEV( dc, pSetDeviceGammaRamp );
> +            struct gamma_ramp
> +            {
> +                WORD red[256];
> +                WORD green[256];
> +                WORD blue[256];
> +            } *ramp = ptr;
> +
> +            if (!check_gamma_ramp(ramp->red) ||
> +                !check_gamma_ramp(ramp->green) ||
> +                !check_gamma_ramp(ramp->blue))
> +                return FALSE;

This can't work.

-- 
Alexandre Julliard
julliard@winehq.org



[prev in list] [next in list] [prev in thread] [next in thread]