[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/2] winmm: MCI_BREAK_HWND handling now matches Wine's 1999 MCI_DefYieldProc.
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2013-02-28 21:02:23
Message-ID: 87y5e89mow.fsf () wine ! dyndns ! org
[Download RAW message or body]

<Joerg-Cyril.Hoehle@t-systems.com> writes:

> @@ -2063,9 +2063,10 @@ static	DWORD MCI_Break(UINT wDevID, DWORD dwFlags, LPMCI_BREAK_PARMS lpParms)
>      switch (dwFlags & (MCI_BREAK_KEY | MCI_BREAK_OFF)) {
>      case MCI_BREAK_KEY:
>  	wmd->lpfnYieldProc = MCI_DefYieldProc;
> -	wmd->dwYieldData   = lpParms->nVirtKey;
> -	if (dwFlags & MCI_BREAK_HWND)
> -	    FIXME("(%x) vkey %02X on window %p\n", dwFlags, lpParms->nVirtKey, lpParms->hwndBreak);
> +	/* Our MCI_DefYieldProc from 1999-04-11 expects this DWORD splitting,
> +	 * yet tests on w2k-w7 prove wmd->dwYieldData = lpParms->nVirtKey; */

It doesn't make sense to add workarounds for Wine code, it should be
fixed instead.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]