[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: windowscodecs: Implement GetThumbnail in the ICO frame decoder.
From:       Hans Leidekker <hans () codeweavers ! com>
Date:       2013-01-30 10:28:18
Message-ID: 1359541698.3458.16.camel () t400
[Download RAW message or body]

On Wed, 2013-01-30 at 18:52 +0800, Dmitry Timoshkov wrote:

> > The test added by 6395af1ae7b0cc5f2f1f82796502e2a605bc5a6b says otherwise, GetThumbnail
> > is supported for ICO frames.
> 
> It's still better to return WINCODEC_ERR_CODECNOTHUMBNAIL instead of
> E_INVALIDARG. Real implementation depends on the codec set, and although
> obviously MS implementation returns a real interface, that doesn't mean
> that an implementation that returns WINCODEC_ERR_CODECNOTHUMBNAIL is wrong.

Well, the app that prompted me to write that test wasn't fooled by returning
WINCODEC_ERR_CODECNOTHUMBNAIL (which is what was returned before my patch).

And since you're changing the FIXME to a TRACE you are effectively hiding
the bug.




[prev in list] [next in list] [prev in thread] [next in thread]