[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [1/5] comctl32/tests: more tests for icon spacing calculation
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2013-01-25 8:49:10
Message-ID: 51024706.3090403 () gmail ! com
[Download RAW message or body]

On 1/25/2013 12:47, Daniel Jelinski wrote:
> Hello,
> Thanks for reviewing. What's the preferred way of checking whether the
> code is compiled for 32 or 64bit?
> Regards,
> Daniel
Check for pointer size.
>
> 2013/1/24 Alexandre Julliard <julliard@winehq.org>:
>> Daniel Jelinski <djelinski1@gmail.com> writes:
>>
>>> +#ifdef _WIN64
>>> +    /* NOTE: -1 is not treated the same as (DWORD)-1 by 64bit listview */
>>> +    ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, (DWORD)-1);
>>> +todo_wine {
>>> +    expect(100, LOWORD(ret));
>>> +    expect(0xFFFF, HIWORD(ret));
>>> +}
>>> +    ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, 0xBAADF00DDEADBEEFLL);
>> Please avoid ifdefs and long long constants.
>>
>> --
>> Alexandre Julliard
>> julliard@winehq.org
>
>



[prev in list] [next in list] [prev in thread] [next in thread]