[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Help Splitting Patches
From:       Eric Pouech <eric.pouech () orange ! fr>
Date:       2012-12-31 8:40:30
Message-ID: 50E14F7E.2080801 () orange ! fr
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Le 30/12/2012 22:52, Adam Martinson a écrit :
> Looking for some help splitting patch 3, not sure how I can cut it 
> down any more without breaking stuff.  I'm guessing patch 9 will need 
> splitting too, same problem.
>
I haven't checked whether it's really possible, but one way to go would 
be to:
- create a dedicated structure like server_end for the server end-point 
(instead of directly reusing the existing pipe_end)
- then patch by patch move elements from pipe_instance to server_end
     + options
     + fd
     + ...
- finally, when server_end and pipe_end have the same fields, just drop 
server_end for pipe_end

HTH
A+

[Attachment #5 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Le 30/12/2012 22:52, Adam Martinson a
      &eacute;crit&nbsp;:<br>
    </div>
    <blockquote cite="mid:50E0B784.1060908@gmail.com" type="cite">Looking
      for some help splitting patch 3, not sure how I can cut it down
      any more without breaking stuff.&nbsp; I'm guessing patch 9 will need
      splitting too, same problem.
      <br>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
    </blockquote>
    I haven't checked whether it's really possible, but one way to go
    would be to:<br>
    - create a dedicated structure like server_end for the server
    end-point (instead of directly reusing the existing pipe_end)<br>
    - then patch by patch move elements from pipe_instance to server_end<br>
    &nbsp;&nbsp;&nbsp; + options<br>
    &nbsp;&nbsp;&nbsp; + fd<br>
    &nbsp;&nbsp;&nbsp; + ...<br>
    - finally, when server_end and pipe_end have the same fields, just
    drop server_end for pipe_end<br>
    <br>
    HTH<br>
    A+<br>
  </body>
</html>




[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic