[prev in list] [next in list] [prev in thread] [next in thread]
List: wine-devel
Subject: Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW (try 2)
From: Dmitry Timoshkov <dmitry () baikal ! ru>
Date: 2012-12-29 3:57:17
Message-ID: 20121229125337.83a0a2e6.dmitry () baikal ! ru
[Download RAW message or body]
Stefan Leichter <Stefan.Leichter@camline.com> wrote:
> First of all: The issues your are pointing out have been in the previous
> version of the patch too. Why didn't you complain in your first review. To my
> understanding this is a wast of my time complaining about two issues and
> keeping the rest secret for the next version of the patch.
It's often happens with subsequent reviews, and there is nothing magic or
secret about it: first review was about the whole approach while next one
is more about the actual details.
> Now to the technical stuff:
> - i agree to change the data type to WCHAR
> - what you mean with "protect from insufficient buffer size" it totaly unclear to
> me
I intentionally left 'BYTE buffer[MAX_PATH];' in the quote, think about it.
> - the tests are written for a font in %windor%\fonts. This directory is empty
> after a clean .wine directory was created. Changing the font does not help at
> all.
But it will once Wine starts to copy its own fonts there at some point.
--
Dmitry.
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic