[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Aw: Re: [PATCH] comdlg32/tests: Accept win8 failure-code
From:       Dmitry Timoshkov <dmitry () baikal ! ru>
Date:       2012-12-26 2:26:05
Message-ID: 20121226112216.523aa3cb.dmitry () baikal ! ru
[Download RAW message or body]

"Detlef Riekenberg" <wine.dev@web.de> wrote:

> >> + /* win8: E_NOTIMPL */
> >> + ok(hr == E_FAIL || hr == E_NOTIMPL, "got 0x%08x.\n", hr);
> 
> >A usual form for such comparisons is
> >ok(hr == E_FAIL || hr == E_NOTIMPL /* win8 */, "got 0x%08x.\n", hr);
> I disagree!
> 
> Comments at the end of a line are ok,
> but a comment in the middle /* broken */ of a line decrease /* ugly by design */ the readability
> of the code /* not compiler related */ for humans/developers a lot and should be allowed
> only for backwards compatibility.

You are confusing a sentence and a set of statements.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]