[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] cabinet: Turn some ERR into WARN and improved or fix messages.
From:       Christian Costa <titan.costa () gmail ! com>
Date:       2012-11-27 11:55:44
Message-ID: CAMo6X8ZpC8kz1VGnFXB8ZgJVXvpL5VyZsr_kU-EVOHVFW-WFLw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> -BOOL __cdecl FDIIsCabinet(
>> -       HFDI            hfdi,
>> -       INT_PTR         hf,
>> -       PFDICABINETINFO pfdici)
>> +BOOL __cdecl FDIIsCabinet(HFDI hfdi, INT_PTR hf, PFDICABINETINFO pfdici)
>>   {
>>     BOOL rv;
>>     FDI_Int *fdi = get_fdi_ptr( hfdi );
>> @@ -749,13 +746,13 @@ BOOL __cdecl FDIIsCabinet(
>>     if (!fdi) return FALSE;
>>       if (!hf) {
>> -    ERR("(!hf)!\n");
>> +    WARN("No file handle\n");
>>       SetLastError(ERROR_INVALID_**HANDLE);
>>       return FALSE;
>>     }
>>       if (!pfdici) {
>> -    ERR("(!pfdici)!\n");
>> +    WARN("No cab info pointer\n");
>>       SetLastError(ERROR_BAD_**ARGUMENTS);
>>       return FALSE;
>>     }
>>
> This call already has a TRACE earlier, I don't see a point in tracing
> input parameters multiple times.
>
>>
>>
Indeed. That would be better to remove them. Thanks.

[Attachment #5 (text/html)]

<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div \
class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">

-BOOL __cdecl FDIIsCabinet(<br>
-       HFDI            hfdi,<br>
-       INT_PTR         hf,<br>
-       PFDICABINETINFO pfdici)<br>
+BOOL __cdecl FDIIsCabinet(HFDI hfdi, INT_PTR hf, PFDICABINETINFO pfdici)<br>
  {<br>
    BOOL rv;<br>
    FDI_Int *fdi = get_fdi_ptr( hfdi );<br>
@@ -749,13 +746,13 @@ BOOL __cdecl FDIIsCabinet(<br>
    if (!fdi) return FALSE;<br>
      if (!hf) {<br>
-    ERR(&quot;(!hf)!\n&quot;);<br>
+    WARN(&quot;No file handle\n&quot;);<br>
      SetLastError(ERROR_INVALID_<u></u>HANDLE);<br>
      return FALSE;<br>
    }<br>
      if (!pfdici) {<br>
-    ERR(&quot;(!pfdici)!\n&quot;);<br>
+    WARN(&quot;No cab info pointer\n&quot;);<br>
      SetLastError(ERROR_BAD_<u></u>ARGUMENTS);<br>
      return FALSE;<br>
    }<br>
</blockquote></div></div>
This call already has a TRACE earlier, I don&#39;t see a point in tracing input \
parameters multiple times.<div class="HOEnZb"><div class="h5"><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> \
<br></blockquote></div></div></blockquote><div><br></div><div>Indeed. That would be \
better to remove them. Thanks. </div></div>





[prev in list] [next in list] [prev in thread] [next in thread]