[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [02/10] windowscodecs: Reimplement QueryCapability of the BMP decoder.
From:       Dmitry Timoshkov <dmitry () baikal ! ru>
Date:       2012-11-23 6:51:41
Message-ID: 20121123154857.ecd66fda.dmitry () baikal ! ru
[Download RAW message or body]

Vincent Povirk <madewokherd@gmail.com> wrote:

> Does QueryCapability really QueryCapability? Can you get a
> frame out of it? I guess it never occurred to me to try.

I've added a test that confirms that GetFrame succeeds after a successful
QueryCapability call.

> I was OK with this for the other implementations because I figured
> it'd be easy enough to invalidate the decoder after successfully
> calling Initialize, if that turned out to be a problem.

Yes, that was also my impression that implementing QueryCapability using
Initialize and then undo the changes would be an obvious (and easy to do)
way to implement it, but apparently MS developers decided leave the state of
the decoder unchanged (that's a really confusing behaviour of QueryCapability
if you ask me).

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]