[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [3/5] d3dx9: Introduce a function for copying pixels.
From:       Matteo Bruni <matteo.mystral () gmail ! com>
Date:       2012-10-29 11:47:41
Message-ID: CABvNrtMnSYW4+uNbVtXRmk-JMft8OOFcLpcEaDwjJa=WXdoXcw () mail ! gmail ! com
[Download RAW message or body]

2012/10/29 Christian Costa <titan.costa@gmail.com>:
>
>>
>>      pixel_format = get_format_info(src_desc.Format);
>> -    if (pixel_format->type != FORMAT_ARGB)
>> -    {
>> -        FIXME("Unsupported pixel format %#x\n", src_desc.Format);
>> -        return E_NOTIMPL;
>> -    }
>> +    if (pixel_format->type == FORMAT_UNKNOWN) return E_NOTIMPL;
>>
>>
>
>  Doesn't this still require a FIXME or at least a WARN?
>

There is still a FIXME in get_format_info(), that's enough I guess.


[prev in list] [next in list] [prev in thread] [next in thread]