[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: d3dx9_36 [patch 1/6]: Implement D3DXSHMultiply4
From:       Rico_Schüller <kgbricola () web ! de>
Date:       2012-09-27 8:55:50
Message-ID: 50641496.2070200 () web ! de
[Download RAW message or body]

On 27.09.2012 09:56, Nozomi Kodama wrote:
> +FLOAT* WINAPI D3DXSHMultiply4(FLOAT *out, CONST FLOAT *a, CONST FLOAT *b)
FLOAT * WINAPI D3DXSHMultiply4(FLOAT *out, const FLOAT *a, const FLOAT *b)
A minor nitpick, anyone against something like? I think that was what 
Matteo meant in 
http://www.winehq.org/pipermail/wine-devel/2012-September/096924.html 
with "Fix the FLOAT*"?

> +    TRACE("(%p, %p, %p)\n", out, a, b);
I would probably prefer:
TRACE("out %p, a %p, b %p\n", out, a, b);
I know the other Multiply functions and so on use your trace format...

> +    out[0]  = 0.28209479f * a[0] * b[0];
There are still double spaces ... Hint: it's not the only occurrence.

Cheers
Rico


[prev in list] [next in list] [prev in thread] [next in thread]