[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: kernel32: Add UTF-7 support. (try 5)
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2012-08-31 7:54:16
Message-ID: 87d327h4yf.fsf () wine ! dyndns ! org
[Download RAW message or body]

Alex Henrie <alexhenrie24@gmail.com> writes:

> Try 5 adds two tests for the case where srclen < -1 and passes them both.

You are still overflowing the source.

You need to spend more time on this. You also need to split the patch,
and write some sort of table-driven tests so you can test a lot more
cases, the ones you have are clearly not sufficient.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]