[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/3] ntdll: Support TokenIntegrityLevel in NtQueryInformationToken
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2012-07-29 4:06:33
Message-ID: 5014C303.6040900 () gmail ! com
[Download RAW message or body]

On 7/29/2012 02:24, Detlef Riekenberg wrote:
> +        {
> +            /* report always "S-1-16-12288" (high mandatory level) */
> +            static BYTE high_level[] = {1,              /* SID_VERSION */
> +                                        1,              /* One SubAuthority entry */
> +                                        0,0,0,0,0,16,   /* SECURITY_MANDATORY_LABEL_AUTHORITY */
> +                                        0,0x30,0,0};    /* SECURITY_MANDATORY_HIGH_RID */
> +
This is ugly. Better way is:

static const SID highlabel = { SID_REVISION, 1, { 
SECURITY_MANDATORY_LABEL_AUTHORITY}, { SECURITY_MANDATORY_HIGH_RID } };

and comment is not needed after that cause level is now obvious with 
these defines.




[prev in list] [next in list] [prev in thread] [next in thread]