[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [1/5] windowscodecs: Implement IWICBitmapScaler::GetSize.
From:       Vincent Povirk <madewokherd () gmail ! com>
Date:       2012-06-27 16:29:11
Message-ID: CAG_NDKpWisgB6EDUDP7uJbn1zg1dY8LFc95gMBGX0SGzbfiw-w () mail ! gmail ! com
[Download RAW message or body]

Good point. I'll resend with parameter checking.

On Wed, Jun 27, 2012 at 11:25 AM, Dmitry Timoshkov <dmitry@baikal.ru> wrote:
> Vincent Povirk <madewokherd@gmail.com> wrote:
>
>>  static HRESULT WINAPI BitmapScaler_GetSize(IWICBitmapScaler *iface,
>>      UINT *puiWidth, UINT *puiHeight)
>>  {
>> -    FIXME("(%p,%p,%p): stub\n", iface, puiWidth, puiHeight);
>> +    BitmapScaler *This = impl_from_IWICBitmapScaler(iface);
>> +    TRACE("(%p,%p,%p)\n", iface, puiWidth, puiHeight);
>>
>> -    return E_NOTIMPL;
>> +    if (!This->source)
>> +        return WINCODEC_ERR_WRONGSTATE;
>> +
>> +    *puiWidth = This->width;
>> +    *puiHeight = This->height;
>> +
>> +    return S_OK;
>
> This patch and remaning patches in the sequence completely miss any
> parameter checking.
>
> --
> Dmitry.



[prev in list] [next in list] [prev in thread] [next in thread]