[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)
From:       Alexey Slepov <sir-lexa () yandex ! ru>
Date:       2012-05-31 20:28:31
Message-ID: 142411338496111 () web19f ! yandex ! ru
[Download RAW message or body]

Guys, so how about this?

diff --git a/dlls/user32/tests/dialog.c b/dlls/user32/tests/dialog.c
index 6bd34b3..4301c8d 100644
--- a/dlls/user32/tests/dialog.c
+++ b/dlls/user32/tests/dialog.c
@@ -1027,9 +1027,6 @@ static INT_PTR CALLBACK DestroyOnCloseDlgWinProc (HWND hDlg, \
UINT uiMsg, šššššcase WM_CLOSE:
šššššššššDestroyWindow(hDlg);
šššššššššreturn TRUE;
- šššcase WM_DESTROY:
- šššššššPostQuitMessage(0);
- šššššššreturn TRUE;
ššššš}
šššššreturn FALSE;
š}


29.05.2012, 01:16, "Alexey Slepov" <sir-lexa@yandex.ru>:

> šI figured out now.
> šAs described in wine sources, PostQuitMessage() sets a flag in the thread's \
> message queue that signals it to generate ša WM_QUIT message when there are no \
> other pending sent or posted messages in the queue. šThe tests with skipped \
> testcases are those which use WM_TIMER messages - test_timer_message() and my test. \
> šIn DIALOG_DoDialogBox() there is clearly defined that on receiving WM_QUIT message \
> the window is destroyed. So timer messages just do not reach queue. 
> šI thought about solution again and now I think that it would be better to remove \
> at all lines about WM_DESTROY handling, such as we don't handle this message. And \
> let it be handled by default. That code does nothing except posting WM_QUIT \
> messages leading to test skipping. (test passed on WineBot) 
> šWhat do you think?
> 
> 
> š28.05.2012, 10:32, "Dmitry Timoshkov" <dmitry@baikal.ru>:
> > ššsir-lexa <sir-lexa@yandex.ru> wrote:
> > > ššššššššcase WM_DESTROY:
> > > ššš- šššššššPostQuitMessage(0);
> > > ššš+ ššššššš/* PostQuitMessage(0); ššIt lets some tests to be skipped */
> > > ššššššššššššreturn TRUE;
> > ššThis is not acceptable, there is much more behind the scene. You need
> > ššto figure out the real reason of skipping the tests.
> > 
> > šš--
> > ššDmitry.


[prev in list] [next in list] [prev in thread] [next in thread]