[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: dinput: Support INFINITE as number of effect iterations (try 2)
From:       Marcel Hasler <mahasler () gmail ! com>
Date:       2012-01-30 15:20:21
Message-ID: CAOJOY2Mx+LV86PV_wgdCP8_CLmcN-wKFzKNickWaWLT0KFm00g () mail ! gmail ! com
[Download RAW message or body]

2012/1/30 Vitaliy Margolen <wine-devel@kievinfo.com>:
>
> I'm afraid you'll have to dig up some documentation about what is the max
> value here is then. The fact that it works doesn't mean it's correct.
>
> Vitaliy.
>
>

The only official documentation I can find is in
Documentation/input/ff.txt and it doesn't say anything about the max
for 'value'.  I had a look at the kernel source instead.
input_handle_event() in input.c only checks whether 'value' is >= 0
for EV_FF (which is why the event is ignored for INFINITE),
ml_ff_playback() in ff-memless.c sets 'state->count' (which is an
'int') to 'value' and ml_get_combo_effect() finally counts down
'state->count' until it reaches zero. So there really is no limit here
(accept what's given by the data type).

Marcel


[prev in list] [next in list] [prev in thread] [next in thread]