'Re: [PATCH] wininet: Initialize netconn_stream's content_length'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] wininet: Initialize netconn_stream's content_length
From:       Jacek Caban <jacek () codeweavers ! com>
Date:       2011-11-23 10:15:00
Message-ID: 4ECCC7A4.8070403 () codeweavers ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On 11/23/11 04:17, Andy Clayton wrote:
> On Tue, Nov 22, 2011 at 9:28 AM, Andy Clayton <q3aiml@gmail.com 
> <mailto:q3aiml@gmail.com>> wrote:
>
>     Hi Jacek,
>
>     On Tue, Nov 22, 2011 at 3:59 AM, Jacek Caban
>     <jacek@codeweavers.com <mailto:jacek@codeweavers.com>> wrote:
>
>         This doesn't seem right. At the point where we call
>         HTTP_ReceiveRequestData, content_length is supposed to be set
>         based on response header. The bug must be somewhere else.
>
>
>     Thanks for looking over my patch. So it seems then that
>     HTTP_HttpSendRequestW should not be calling
>     HTTP_ReceiveRequestData if bEndRequest is false (http.c:4941),
>     since there is no way at that point it could have read the
>     headers. Is that a better fix?
>
>     Thanks again for your help,
>
>     Andy
>
>
> I've attached a second attempt showing this. Thanks for any thoughts 
> you can provide.

This patch looks good to me.

Thanks,
     Jacek

[Attachment #5 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    On 11/23/11 04:17, Andy Clayton wrote:
    <blockquote
cite="mid:CALub+Nu5+fiEyhhwu-jv9LXvRpi2eQDuQ44KWzAw1ROpMDTCxA@mail.gmail.com"
      type="cite">
      <div class="gmail_quote">On Tue, Nov 22, 2011 at 9:28 AM, Andy
        Clayton <span dir="ltr">&lt;<a moz-do-not-send="true"
            href="mailto:q3aiml@gmail.com">q3aiml@gmail.com</a>&gt;</span>
        wrote:<br>
        <blockquote class="gmail_quote" style="margin:0 0 0
          .8ex;border-left:1px #ccc solid;padding-left:1ex;">
          Hi Jacek,<br>
          <br>
          <div class="gmail_quote">
            <div class="im">On Tue, Nov 22, 2011 at 3:59 AM, Jacek Caban
              <span dir="ltr">&lt;<a moz-do-not-send="true"
                  href="mailto:jacek@codeweavers.com" \
target="_blank">jacek@codeweavers.com</a>&gt;</span>  wrote:<br>
              <blockquote class="gmail_quote" style="margin:0 0 0
                .8ex;border-left:1px #ccc solid;padding-left:1ex">
                This doesn't seem right. At the point where we call
                HTTP_ReceiveRequestData, content_length is supposed to
                be set based on response header. The bug must be
                somewhere else.<span></span><br>
              </blockquote>
            </div>
            <div>
              <br>
              Thanks for looking over my patch. So it seems then that
              HTTP_HttpSendRequestW should not be calling
              HTTP_ReceiveRequestData if bEndRequest is false
              (http.c:4941), since there is no way at that point it
              could have read the headers. Is that a better fix?<br>
              <br>
              Thanks again for your help,<br>
              <br>
              Andy <br>
            </div>
          </div>
          <br>
        </blockquote>
      </div>
      <br>
      I've attached a second attempt showing this. Thanks for any
      thoughts you can provide.<br>
    </blockquote>
    <br>
    This patch looks good to me.<br>
    <br>
    Thanks,<br>
    &nbsp;&nbsp;&nbsp; Jacek<br>
  </body>
</html>





[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic