[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: winmm: waveOutReset returns all buffers.
From:       Dan Kegel <dank () kegel ! com>
Date:       2011-09-27 16:59:39
Message-ID: CAPF-yOZ129C-gANxbwg_QmVN=SXxb-vQ29er672HOu3DmJb5sw () mail ! gmail ! com
[Download RAW message or body]

On Tue, Sep 27, 2011 at 11:35 AM,  <Joerg-Cyril.Hoehle@t-systems.com> wrote:
> This raises the question about when to use [PATCH X/Y] and/or whether
> buildbots should apply all precedingly submitted patches that did not fail.
>
> I tend to use X/Y subject lines when patches depend on each other in the
> sense that one should not apply patch #2 without #1.
>
> There was no such dependency here, one could commit or reject each individually.
>
> The only particularity about yesterday's patches is that there were 2 patches
> to the same function, waveOutReset. Trying to apply the second one without
> the first obviously needs a "fuzz", yet the second patch *can* be used stand alone.
>
> Luckily, AJ is much smarter than the bot, and all patches went in.

Yeah.  On the other hand, he specifically requested that buildbot
be strict about not allowing fuzz.  I *think* that implies he'd
prefer the X/Y notation if it's required to prevent fuzz.
- Dan


[prev in list] [next in list] [prev in thread] [next in thread]