[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/4] msi: speed up WHERE statement evaluation by
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2011-08-31 10:25:11
Message-ID: 87pqjlsws8.fsf () wine ! dyndns ! org
[Download RAW message or body]

Bernhard Loos <bernhardloos@googlemail.com> writes:

> @@ -639,6 +715,8 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, MSIRECORD *record )
>      while ((table = table->next));
>  
>      rows = msi_alloc( wv->table_count * sizeof(*rows) );
> +    memset( rows, 0xFF, sizeof( rows ) );
> +

If the goal is to set them to -1, please do that explicitly. Also
defining some appropriate constant for invalid rows would be even
better.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]