[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/4] shell32: Implement erasing and restoring items from
From:       Juan Lang <juan.lang () gmail ! com>
Date:       2011-06-30 16:37:14
Message-ID: BANLkTi=vp6qHmNkzfGdq+j-S-58Hixna5T0WVn37Q0+yxeTyGA () mail ! gmail ! com
[Download RAW message or body]

Hi Jay,

+HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl){

Nit: the brace should be on its own line.

+HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN;
+HRESULT TRASH_EraseItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN;

These two functions are never called in this patch, so you're
introducing dead code.  That's not allowed.  Introduce the functions
in the patch that uses them, please.  If the resulting patch is too
large, you must split it another way.
--Juan


[prev in list] [next in list] [prev in thread] [next in thread]