[prev in list] [next in list] [prev in thread] [next in thread]
List: wine-devel
Subject: Re: oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
From: Michael Stefaniuc <mstefani () redhat ! com>
Date: 2011-06-27 11:55:54
Message-ID: 4E086FCA.7080509 () redhat ! com
[Download RAW message or body]
Hello Alistair,
Alistair Leslie-Hughes wrote:
> Changelog:
> oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
>
> dlls/oleaut32/typelib2.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c
> index e9c7613..459547f 100644
> --- a/dlls/oleaut32/typelib2.c
> +++ b/dlls/oleaut32/typelib2.c
> @@ -3067,8 +3067,13 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetHelpStringContext(
> ICreateTypeInfo2* iface, /* [I] The typeinfo on which to set the help string context. */
> ULONG dwHelpStringContext) /* [I] The help string context. */
> {
> - FIXME("(%p,%d), stub!\n", iface, dwHelpStringContext);
> - return E_OUTOFMEMORY;
> + ICreateTypeInfo2Impl *This = (ICreateTypeInfo2Impl *)iface;
please do not add any more of those cast but add a
impl_from_ICreateTypeInfo2() helper as per the COM guidline at
http://wiki.winehq.org/COMGuideline. Bonus points for doing the COM
cleanup too ;)
thanks
bye
michael
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic