[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [1/5] wined3d: Add missing temporary variable declaration to ARB
From:       Stefan_Dösinger <stefandoesinger () gmx ! at>
Date:       2011-04-29 9:49:00
Message-ID: D5D9B42B-7C8D-42D1-8F49-9BC93377068A () gmx ! at
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/alternative)]


Am 29.04.2011 um 00:39 schrieb Matteo Bruni:

> 2011/4/29 Stefan Dösinger <stefandoesinger@gmx.at>:
>>> +    shader_addline(buffer, "TEMP TB;\n");
>> Which shader instruction uses this? Afair vertex shaders should only use TA,
>> but there's no proper infrastructure that manages that.
>> 
> 
> AFAICS, TB could get used in shader_hw_pow():
> 
> ...
>    shader_arb_get_src_param(ins, &ins->src[1], 1, src1);
> ...
> 
> where the '1' in the third argument means that
> shader_arb_get_src_param() is allowed to use TB as temporary storage.
> There may be other pieces of code with the same assumption, I didn't
> look deeper.
Ok


[Attachment #7 (unknown)]

<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space; "><br><div><div>Am 29.04.2011 um 00:39 schrieb \
Matteo Bruni:</div><br class="Apple-interchange-newline"><blockquote \
type="cite"><div>2011/4/29 Stefan Dösinger &lt;<a \
href="mailto:stefandoesinger@gmx.at">stefandoesinger@gmx.at</a>&gt;:<br><blockquote \
type="cite"><blockquote type="cite">+ &nbsp; &nbsp;shader_addline(buffer, "TEMP \
TB;\n");<br></blockquote></blockquote><blockquote type="cite">Which shader \
instruction uses this? Afair vertex shaders should only use \
TA,<br></blockquote><blockquote type="cite">but there's no proper infrastructure that \
manages that.<br></blockquote><blockquote type="cite"><br></blockquote><br>AFAICS, TB \
could get used in shader_hw_pow():<br><br>...<br> \
&nbsp;&nbsp;&nbsp;shader_arb_get_src_param(ins, &amp;ins-&gt;src[1], 1, \
src1);<br>...<br><br>where the '1' in the third argument means \
that<br>shader_arb_get_src_param() is allowed to use TB as temporary \
storage.<br>There may be other pieces of code with the same assumption, I \
didn't<br>look deeper.<font class="Apple-style-span" color="#000000"><font \
class="Apple-style-span" \
color="#144FAE"><br></font></font></div></blockquote>Ok</div><div><br></div></body></html>



["PGP.sig" (application/pgp-signature)]



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic