[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: comctl32/tests: Remove practically unused parameters from test
From:       Michael Stefaniuc <mstefani () redhat ! com>
Date:       2011-04-28 21:34:35
Message-ID: 4DB9DD6B.3060507 () redhat ! com
[Download RAW message or body]

On 04/28/2011 02:05 AM, Vitaliy Margolen wrote:
> On 04/27/2011 09:47 AM, Nikolay Sivov wrote:
>> On 4/27/2011 17:53, Vitaliy Margolen wrote:
>>> On 04/27/2011 01:14 AM, Nikolay Sivov wrote:
>>>> Remove practically unused parameters from test functions
>>>>
>>>
>>> So how is global variable any better then local variable passed as
>>> function parameter?
>> Because there's no need to have different parent windows for currently
>> present tests. I don't see a reason of
>> having window handle created exactly once and then passed in each test
>> function, it's tests after all with a straightforward structure.
> The reason - all global variables are bad, do not use them. Regardless
> why and how they are created and/or used.
All generalizations are bad, do not use them.

bye
	michael


[prev in list] [next in list] [prev in thread] [next in thread]