[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: shlwapi/tests: remove win9x hacks (try 2)
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2011-02-28 22:36:27
Message-ID: 4D6C236B.9040107 () gmail ! com
[Download RAW message or body]

On 3/1/2011 01:28, Austin English wrote:
> Apparently it's flaky on win2k...cleared WTB:
> https://testbot.winehq.org/JobDetails.pl?Key=9585
> -    /* shlwapi on Win98 SE does not appear to apply delimiters to the output
> -     * and does not correctly handle extremely large values. */
> -    ok(!strcmp(result->kb_size, szBuff) ||
> -      (result->kb_size_broken&&  !strcmp(result->kb_size2, szBuff)),
> -        "Formatted %x%08x wrong: got %s, expected %s\n",
> +    ok(!strcmp(result->kb_size, szBuff), "Formatted %x%08x wrong: got %s, expected %s\n",
>          (LONG)(result->value>>  32), (LONG)result->value, szBuff, result->kb_size);
I think it's better to keep comments that describe version dependent 
behaviour even if it's not tested by default now.



[prev in list] [next in list] [prev in thread] [next in thread]