[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: d3dx9_36: Stub ID3DXRenderToSurface, with tests
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2011-02-28 12:58:08
Message-ID: AANLkTimpAi1+qWvUm_=Kxg+vrd2HcqbRtNtoRurNLiH8 () mail ! gmail ! com
[Download RAW message or body]

On 27 February 2011 20:22, Misha Koshelev <misha680@gmail.com> wrote:
> +static HRESULT WINAPI ID3DXRenderToSurfaceImpl_QueryInterface(ID3DXRenderToSurface \
> *iface, REFIID riid, void **ppobj) +{
> +    ID3DXRenderToSurfaceImpl *This = impl_from_ID3DXRenderToSurface(iface);
You don't actually need "This" here.

> +        return D3D_OK;
S_OK is more appropriate for QueryInterface.

> +    WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj);
> +    return E_NOINTERFACE;
> +}
You should set "*ppobj" to NULL here, unless there's a reason not to.


[prev in list] [next in list] [prev in thread] [next in thread]