[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    =?iso-8859-2?Q?Re:_sound_issues_=28which_are_not_cared_since_1.3.1=29?=
From:       wylda () volny ! cz
Date:       2010-12-31 16:07:46
Message-ID: 2d8ae6d66682b64bf2b5d00d3e5e7e99 () mail ! volny ! cz
[Download RAW message or body]

> > 
> > int card, err, capcontrols=0
> > 
> > otherwise things like:
> > 
> > mixdev[mixnum].chans += capcontrols;
> > 
> > mixdev[mixnum].lines =
> > HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> > sizeof(line) * mixdev[mixnum].chans);
> > 
> > 
> > goes crazy like in
> > http://bugs.winehq.org/show_bug.cgi?id=25231#c2.

> 
> well spotted, the patch incorrectly removed the = 0.
> 
> I submitted a patch readding it.

Hi again!

Many thanks Marcus for the patch and getting it git-official :)

I wonder if someone could write a Wiki page about different
techniques how beginners like me can spot and easily test for this
kind of wine's code problems.

Thanks to this bug, Wine-1.3.10 + winecfg's audio tab could be taken
as the example and wiki could show how to use different tools
(warn+heap, valgrind, gcc options, ...) and what tools' output to
expect in case of such bugs.


Regards,
W.

PS: Marcus, i noticed "found by my overflow checking patches" in
http://source.winehq.org/patches/data/69925. Are these patches
publicly available? ;)




[prev in list] [next in list] [prev in thread] [next in thread]