[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite
From:       James McKenzie <jjmckenzie51 () earthlink ! net>
Date:       2010-12-31 3:37:06
Message-ID: 4D1D4FE2.5050107 () earthlink ! net
[Download RAW message or body]

On 12/30/10 12:48 PM, Vitaliy Margolen wrote:
> On 12/30/2010 12:23 PM, Travis Athougies wrote:
>> Tests to ensure the HLSL compiler won't crash on malformed input.
> You still haven't fixed strings spanning multiple lines. Please send a 
> patch that fixes all incorrect strings first. Then continue on with 
> the correct style.
>
> Adding more invalid strings because file already contains some of them 
> isn't a valid reason for broken code.
>
And you keep on forgetting to number your tries.    It looks like you 
are up to try six or seven for this, correct?

James McKenzie



[prev in list] [next in list] [prev in thread] [next in thread]