[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [1/4] winmm/tests: Add tests for mmioOpen for the file name of
From:       Dmitry Timoshkov <dmitry () codeweavers ! com>
Date:       2010-11-30 16:54:43
Message-ID: 20101201005443.c0c55bd6.dmitry () codeweavers ! com
[Download RAW message or body]

Alexander Puzankov <alxpnv@gmail.com> wrote:

> Ok, I missed that MSDN says that the first parameter of the custom I/O procedure
> is of type LPSTR instead of LPMMIOINFO (could be this an error in the
> documentation?).

Both PSDK and Wine headers use the same definition for MMIOPROC.

> I can make cast in mmio_test_IOProc instead, something like:
> 
> static LRESULT CALLBACK mmio_test_IOProc(LPSTR lpMMIOInfo, UINT
> uMessage, LPARAM lParam1, LPARAM lParam2)
> {
>     LPMMIOINFO lpmmioinfo = (LPMMIOINFO) lpMMIOInfo;
>     ...
> }
> 
> So should I remove these casts and resend the entire patchset in the right
> order?

Yes please.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]