[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 4/5] [Kernel32,
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2010-11-29 12:31:10
Message-ID: 87vd3gb9bl.fsf () wine ! dyndns ! org
[Download RAW message or body]

Eric Pouech <eric.pouech@orange.fr> writes:

> @@ -3011,6 +3014,7 @@ BOOL CONSOLE_Init(RTL_USER_PROCESS_PARAMETERS *params)
>              /* reply->event shouldn't be created by server */
>          }
>          SERVER_END_REQ;
> +        fcntl( 0, F_SETFL, O_NONBLOCK );

I don't think that's a good idea, the calling process may not expect
that. Also using overlapped I/O seems overkill considering that you
already have a Unix fd.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]