[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [2/2] msxml3: fix XSLPattern namespace handling
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2010-10-28 10:27:22
Message-ID: 87pquuzk6t.fsf () wine ! dyndns ! org
[Download RAW message or body]

Adam Martinson <amartinson@codeweavers.com> writes:

>  #define U(str) BAD_CAST str
> -#define DBG(str) wine_dbgstr_a((char const*)str)
> +#define DBG(args...) wine_dbg_sprintf((char const*)args)
> +#define RULE(name, args...) TRACE("Got "#name": %s\n", DBG(args))

Again, you can't use varargs macros.

You have a tendency to abuse macros, please try to avoid them as much as
possible. In this case, replacing a standard TRACE by a file-specific
macro is not an improvement, even if it saves a little typing. People
must be able to understand your code without having to look up a ton of
obscure #defines.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic