[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [1/2] msxml3/httprequest: Store passed data
From:       Jacek Caban <jacek () codeweavers ! com>
Date:       2010-09-28 11:51:59
Message-ID: 4CA1D6DF.9030308 () codeweavers ! com
[Download RAW message or body]

  Hi Nikolay,

On 9/28/10 1:30 PM, Nikolay Sivov wrote:
> Resent for series completeness.

+    hr = VariantChangeType(&str,&user, 0, VT_BSTR);
+    if (hr == S_OK)
+    {
+        This->user = SysAllocString(V_BSTR(&str));
+        VariantClear(&str);
+    }

You already own the reference to string in str VARIANT, so you can just use it \
|This->user = V_BSTR(&str);| and remove VariantClear call.


+    hr = VariantChangeType(&str,&password, 0, VT_BSTR);
+    if (hr == S_OK)
+    {
+        This->password = SysAllocString(V_BSTR(&str));
+        VariantClear(&str);
+    }

Same here.


Jacek


[prev in list] [next in list] [prev in thread] [next in thread]