[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 04/12] [Server]: enhanced the console input object so that
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2010-08-30 15:55:15
Message-ID: 8739twumcc.fsf () wine ! dyndns ! org
[Download RAW message or body]

Eric Pouech <eric.pouech@orange.fr> writes:

> +        if (tcgetattr(fd, &term) < 0) fprintf(stderr, "Couldn't get termios\n");
> +        console_input->termios = term;
> +        term.c_lflag &= ~(ECHO | ECHONL | ICANON | IEXTEN);
> +        term.c_iflag &= ~(BRKINT | ICRNL | INPCK | ISTRIP | IXON);

Errors need to be handled properly in the server, you can't just print a
message and continue as if nothing happened.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]