[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] d3dx9_36/tests: Added HLSL test suite. (Try 2)
From:       Jeff Zaroyko <jeffzaroyko () gmail ! com>
Date:       2010-07-31 3:41:34
Message-ID: AANLkTimwsNt-zYi7DUUNbqyPtJxutKiHAmdVj=LPiQ3+ () mail ! gmail ! com
[Download RAW message or body]

On Sat, Jul 31, 2010 at 1:21 PM, Marvin <testbot@testbot.winehq.org> wrote:
>
> === WXPPROSP3 (32 bit hlsl) ===
> hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
> No test summary line found
> ...further CreateDevice test failures snipped...

Is the purpose of these tests device creation?  If not, then it
doesn't really make any sense to do:

> ok(SUCCEEDED(hres), "Could not create device, IDirect3D9_CreateDevice returned: %08x\n", hres);

It would make more sense to just test the result of SUCCEEDED(hres)
and then skip the tests if it's not possible to create the device
rather than counting it as a failed test.

Jeff


[prev in list] [next in list] [prev in thread] [next in thread]