[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 5/9] mciqtz32: Fix window visibility
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2010-07-30 12:49:56
Message-ID: 874ofhqgln.fsf () wine ! dyndns ! org
[Download RAW message or body]

Maarten Lankhorst <m.b.lankhorst@gmail.com> writes:

> @@ -757,15 +757,12 @@ static DWORD MCIQTZ_mciWindow(UINT wDevID, DWORD dwFlags, LPMCI_DGV_WINDOW_PARMS
>          return 0;
>  
>      if (dwFlags & MCI_DGV_WINDOW_HWND && (IsWindow(lpParms->hWnd) || !lpParms->hWnd)) {
> -        LONG style = 0;
>          TRACE("Setting hWnd to %p\n", lpParms->hWnd);
>          IVideoWindow_put_Visible(wma->vidwin, OAFALSE);
> -        IVideoWindow_get_WindowStyle(wma->vidwin, &style);
> -        style &= ~WS_CHILD;
>          if (lpParms->hWnd)
> -            IVideoWindow_put_WindowStyle(wma->vidwin, style|WS_CHILD);
> +            IVideoWindow_put_WindowStyle(wma->vidwin, WS_CHILD);
>          else
> -            IVideoWindow_put_WindowStyle(wma->vidwin, style);
> +            IVideoWindow_put_WindowStyle(wma->vidwin, 0);

This doesn't look right. Why do you want to clear all the style bits?

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]