[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/3] shell32: Use more accurate PathIsURL instead of
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2010-06-28 11:29:16
Message-ID: 87fx072y5v.fsf () wine ! dyndns ! org
[Download RAW message or body]

Andrew Eikum <aeikum@codeweavers.com> writes:

> diff --git a/dlls/shell32/shfldr_desktop.c b/dlls/shell32/shfldr_desktop.c
> index 30aea3b..54d13dc 100644
> --- a/dlls/shell32/shfldr_desktop.c
> +++ b/dlls/shell32/shfldr_desktop.c
> @@ -193,7 +193,7 @@ static HRESULT WINAPI ISF_Desktop_fnParseDisplayName (IShellFolder2 * iface,
>          *ppidl = pidlTemp;
>          return S_OK;
>      }
> -    else if (strchrW(lpszDisplayName,':'))
> +    else if (PathIsURLW(lpszDisplayName))
>      {

A better way would be to check the result of the ParseURLW call.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]