[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [TRY 4] [PATCH] user32: horizontal and vertical scrolling of
From:       Dmitry Timoshkov <dmitry () codeweavers ! com>
Date:       2010-03-29 10:58:49
Message-ID: 20100329195849.eaea964c.dmitry () codeweavers ! com
[Download RAW message or body]

Henry Kroll III <henry@comptune.com> wrote:

> +    if (es->region_posx < 0)EDIT_EM_LineScroll(es,-10,0);
> +    else if (es->region_posx > 0)EDIT_EM_LineScroll(es,10,0);
> +    if (es->region_posy < 0)EDIT_EM_LineScroll(es,0,-1);
> +    else if (es->region_posy > 0)EDIT_EM_LineScroll(es,0,1);

Where do -/+10,-/+1 come from? A test case wouldn't hurt. Also please add
some spacing and try to follow the indentation style of existing code.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]