[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: dlls/user32/combo.c: Fix an issue where pressing 's' in a
From:       "David Quintana (gigaherz)" <gigaherz () gmail ! com>
Date:       2009-12-29 14:19:06
Message-ID: f14c8bf20912290619q3edb8bccl29f422a3680f2e05 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


I had already sent a second patch without the C++-style comment. But
regardless,
if you say other parts of the code are also wrong, then I will leave this to
someone
closer to the project, who knows better what is it that should be done here.

2009/12/29 Dmitry Timoshkov <dmitry@codeweavers.com>

> "David Quintana (gigaherz)" <gigaherz@gmail.com> wrote:
>
>  Issue was caused by VK_F4 having the same exact code as a lowercase 's'.
>> So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed
>> the wrong piece of code which was meant to be ONLY for WM_KEYDOWN.
>>
>
> Thanks for spotting this bug. Anyway the fix is not correct. Virtual key
> codes should be tested only in the WM_KEYDOWN handler, WM_CHAR handler
> should test for character codes. Also, as Nikolay asked please don't use
> C++ comments in Wine code.
>
> --
> Dmitry.
>

[Attachment #5 (text/html)]

I had already sent a second patch without the C++-style comment. But regardless, \
<br>if you say other parts of the code are also wrong, then I will leave this to \
someone<br>closer to the project, who knows better what is it that should be done \
here.<br> <br><div class="gmail_quote">2009/12/29 Dmitry Timoshkov <span \
dir="ltr">&lt;<a href="mailto:dmitry@codeweavers.com" \
target="_blank">dmitry@codeweavers.com</a>&gt;</span><br> <blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"><div><div></div><div>&quot;David Quintana \
(gigaherz)&quot; &lt;<a href="mailto:gigaherz@gmail.com" \
target="_blank">gigaherz@gmail.com</a>&gt; wrote:<br>


<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px \
solid rgb(204, 204, 204); padding-left: 1ex;"> Issue was caused by VK_F4 having the \
same exact code as a lowercase &#39;s&#39;.<br> So the code, which treated WM_CHAR \
and WM_KEYDOWN as the same, executed<br> the wrong piece of code which was meant to \
be ONLY for WM_KEYDOWN.<br> </blockquote>
<br></div></div>
Thanks for spotting this bug. Anyway the fix is not correct. Virtual key<br>
codes should be tested only in the WM_KEYDOWN handler, WM_CHAR handler<br>
should test for character codes. Also, as Nikolay asked please don&#39;t use<br>
C++ comments in Wine code.<br>
<br>
-- <br><font color="#888888">
Dmitry.<br>
</font></blockquote></div><br>





[prev in list] [next in list] [prev in thread] [next in thread]