[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: advapi32.dll: Reduce Registry access to MAXIMUM_ALLOWED wherever
From:       Rob Shearman <robertshearman () gmail ! com>
Date:       2009-11-28 21:50:54
Message-ID: 1096648c0911281350j557a36abia48be82de2653d8b () mail ! gmail ! com
[Download RAW message or body]

2009/11/27 Paul Chitescu <paulc@voip.null.ro>:
> Changelog:
>        advapi32.dll: Reduce Registry access to MAXIMUM_ALLOWED wherever possible
>
> Makes read operation succeed on read/only Registry keys.

Needs tests to show that this behaviour matches that on Windows. You
should be able to achieve this by setting an appropriate security
descriptor on the registry key before calling the function you are
changing.

However, the change to get_special_root_hkey looks fine to me. The
rest of your patch isn't easy to review because you haven't generated
the diff with the "-p" option.

-- 
Rob Shearman



[prev in list] [next in list] [prev in thread] [next in thread]