[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: comctl32/tests: make v6 functions inline
From:       André_Hentschel <nerv () dawncrow ! de>
Date:       2009-10-31 10:14:26
Message-ID: 4AEC0E02.60602 () dawncrow ! de
[Download RAW message or body]

Nikolay Sivov schrieb:
> 2009/10/31 André Hentschel <nerv@dawncrow.de>:
> > So that there are no warnings if tests only use the constant variables in that \
> >                 header.
> > ---
> > dlls/comctl32/tests/v6util.h |    4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/dlls/comctl32/tests/v6util.h b/dlls/comctl32/tests/v6util.h
> > index 21a8e4f..ae3dbbe 100644
> > --- a/dlls/comctl32/tests/v6util.h
> > +++ b/dlls/comctl32/tests/v6util.h
> > @@ -56,7 +56,7 @@ static const CHAR manifest[] =
> > "</dependency>\n"
> > "</assembly>\n";
> > 
> > -static void unload_v6_module(ULONG_PTR cookie)
> > +static inline void unload_v6_module(ULONG_PTR cookie)
> > 
> 
> You're using old source tree. Current prototype is:
> 
> ---
> static void unload_v6_module(ULONG_PTR cookie, HANDLE hCtx)
> ---

oops, thank you.

> Why do you need such changes? I don't think inline it's useful here.

Its that old Problem that tests including that header just to use the manifest get \
warnings that they didnt use the static functions. Of course this warnings disappear \
when using inline. Maybe i should wait until my patch is finished and relies on it, \
but somehow its a general problem so ill send a try 2.


-- 

Best Regards, André Hentschel


[prev in list] [next in list] [prev in thread] [next in thread]