[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: mshtml/tests: Fix events test when pointer is on a corner.
From:       Jacek Caban <jacek () codeweavers ! com>
Date:       2009-10-30 13:14:12
Message-ID: 4AEAE6A4.8050404 () codeweavers ! com
[Download RAW message or body]

Hi Nicolas,

Nicolas Le Cam wrote:
> Hi Jacek,
>
> Thanks for feedback.
> It should handle pointer in every corners IMHO, the left corner can
> cause failures in winetest.
>
> I'll try to find a better solution. Do you have any hints ?
>   

The test in line 472 is invalid. It looks like all we can do is check if 
get_x returned something. I'd suggest to set l to 0xdeadbeef before 
get_x call and test that the value has changed (ok(x != 0xdeadbeef, 
...)). That's all we can do. The same applies to get_client[XY] and 
get_offset[XY] tests.


Thanks,
    Jacek



[prev in list] [next in list] [prev in thread] [next in thread]