[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [2/5] WineD3D: Start replacing dxVersion with create flags
From:       Stefan_Dsinger <stefandoesinger () gmx ! at>
Date:       2009-09-30 15:07:13
Message-ID: 2423739A-FA48-4F6B-A24E-E92FCC7E634E () gmx ! at
[Download RAW message or body]

Am 30.09.2009 um 16:47 schrieb Henri Verbeet:

> 009/9/30 Stefan Dsinger <stefandoesinger@gmx.at>:
>> Are the patches ok with you in that case? Otherwise I'll just fix  
>> bug 19365
>> with the old dxVersion hack and implement whatever properly  
>> designed setup
>> you prefer the next time I have a few hours to kill(read: On my 16  
>> hour
>> flight to the google mentor summit later next month)
>>
> Just fix 19365 with a dxVersion check I'd say, that bug has been in
> its current state long enough.
OK

that still leaves the question how to get rid of dxVersion in the long  
run open

We could use the global flags as my patches here do. (I attached the  
full set for reference)

Or we could use API specific flags that are placed close to where the  
difference occurs(ie, a CreateVertexBuffer flag(or a classic usage  
flag that is filtered by d3d8/9). Easy for 4, 5, 8, 9, but is more  
tricky for 2, 3 and 6(flag has to be set during object creation)

4 and 9 could be handled in the client lib as well. For patch 9 we'd  
have to duplicate the stateblock logic in ddraw (or d3d8+d3d9) to make  
GetViewport work correctly during BeginStateblock() - SetRenderTarget  
- EndStateblock.


["patches.zip" (patches.zip)]

PK
>;patches/UXqJqJPK$>;patches/.DS_StoreUXqJqJn@PTٰkWMKh
 mٴQRWl%1KVyӗh9>8QWY㹞ǃƈ[""RԖ7$
f#9	r*"BƥwrCl$f3}f+ff'u֮`hdlbjvZ۴>yvvBqe2!w
 v^[H|D'l-}%2D.DymVs+G2@Ǎ^[nQ[$Fh \
W!CC9CWȹ:VEW!Ѿ]\rN+Ӷ=$#@ƪql:Z{Bϩzg \
*Wַ k>!JcN`5{38Ϟ*:Cퟨɵ]=ŦF, \
}b>uv!jԽ}"}|<=* "iw#][}Q0X1f#z] \
9S	F7rʙp=<uWZ\B/@}_KFfͯ#I޴GF*2B֓{ \
5k]>.C}?!B!B!B!5/PKBݞr<PK \
(>;	__MACOSX/UXqJqJPK \
(>;__MACOSX/patches/UXqJqJPK$>; \
__MACOSX/patches/._.DS_StoreUXqJqJc`cg`b`MLVVP'AH; \
PKܑ(RPK>;5patches/0001-WineD3D-Fix-a-contraditing- \
comment.patchUXqJqJio@EJgJIUm@m6۵U|gmHS(y \
QAx(myיw`ju_̽ιΑ|J`n_>9F`x3YDa̓焃]dp \
2rwȷv߰+t1uJ0ڳf~׫ӋMC?HC&*B*RzblDPX(H3b_QDʸ	%Q]rKuQmD$bR1ឧ \
'̒xe<fe1U55h<y`P\j>  s%Ӥu} \
pު3&de-$6ט?c2 m݋ءKqA x~~ntՋ
ŕ`JQ6tUm	{mʜC{t`s&Poj<g<S9*rzWd.?p?9ݗTK8uoɉI46U@EZm|%.FΘ
 ,d/0G=@ɌGyGJ;xB\	} \
!rq	NYil}G@<"WC5*u\.u)_G?k^ \
6gscPK fPK>;Fpatches/0002-WineD3D-Start-replacing-dxVersion-with-create-flags.patchUXqJqJXmsHίKU\z \
7gD(Vm$`fm !nvij	5hSh[2-SUMSs:fC[ij&!5 \
ʃ	]EPSU ~M?LB[Sn޽l{ \
.ʦO<R?򽤓^gPU1	*] \
eߥZrכ@_3^/`?]b`? X>iqC IjUusnm$̓-^[ \
)Ɏ퓧VRry'/>Nqs>2H6jV:~:'k=E$H<T$2 \
|\kAm GP(+4z%fcK̳34RolJ&
zƑ>Q #TFeqס|t.mnIK_8W0Na{^'$[}CӅ.my˻}1:( \
ױGڛЮ@a8y'JhLT~划xqoDvzoyd&㽩Ľ"\oqw \
Қ	u}]9{'\8c;nr繻p/Y#춌}+=c7H` \
ö7Rejekyt;	TbCx{5->͆:6̮DV{cCiWzz?~C73 \
                q?zg@5!?z"e)
*h0MCs!zBh>kJ;MT/'܄1:5,X<%Y}o2p1Wz0[؍n|
 DlgtDѿ]fɐ(n@xm|?`ʵq؟DU<"c75淣˼?7xīfN_DŨ%~q̀0npFc!#.hrjBȏoO8زҒVKi6ɋtev
 _dv=M7p@p/gb6JNW<bkA#	0>" \
Xd9|bUjU*N3=ڹ|v;ݍSCσti'-Ŵ-[k b<j= \
Oݶ&x`C#>k7f'%Uǡ~!KAJsJ" P+46~DLi { \
Cu7(":BnV(ſLO&)p 5 ?&TdrX>t
q^'h 5
B!ĶE`X?.aIq	?8cb`g'cthl#K4Ȇ]ݟ{O]hٙ/YwJp-BG<<Bg$- \
LR˯2|RK酧KZ?iv~9<(Qp2uy7洆v/%HޮG0[FBDYb=ueH@Cn`4A7 \
w=1`wRXnb4rh<<>2GWg@xZ0k^^S/jIѵ~IokD%ʞV` \
"\(/>iݣqD%HxFμds~)|᝿hx41nFcb1SjD,OItLFGK#>]爯nP4$#
 JWq"&vBMQZHұqqM!%TC]xI \
;F1Wik,~	˹[}	&k<N1sI$/ꯙ3mѮ-hbuYnFavtpnT]:& \
bGZbpIـя4@ աBTbY.2{Nn+w򪟧4*
KG!~?$K *7eM$OPKaPK>;Cpatches/0003-Wi \
neD3D-Add-a-flag-for-static-vertex-buffer-FVFs.patchUXqJqJWmsFίؤ3^drJږFB;milg \
Y&S&ݳ>HWU%){mt:͖Ғەީ-+븲xn.t  \
)I0B7=Xz_)ߔ(C~JnD#hn<t;=zA)ݞI]J.ΟM{T3Aj5dCh
 ^`߁Őv껀QRhQ"z]I~l,m?]y-VGCZyzi^_tTAye*>
 
քr PI-74FI
d'IZN	
h^/=;??'!ALx.i)N$)6'|ǏPoJ5lNL1E$J.n5OOjBv
 5ݏ::dE]ì/оK5/64tc>;$83R374^:~%
FobK 7+Y9iXWڼkcf	\%F"X٘N;7YĈfm>h
n575s<@6Fͼh2b JFep_tBeYEV8y~0VLoV$jP/ \
/a#ォc2Ѻ|һ<P99<3qQEQ21f2R1;ץdratP7(eB
 rժ0[ @39ȘY9#zVT9^:yi<)AdcDE%wixxaҴ[]32k,v17ζŝy-I_ \
aΰKG+;eN{qm9<3ٱ&J7YyAoAR; [
}Ņ@bWdTkY^sӗv {4H(e_E6ӑ`Ӹ#n'oM#V5|eN \
~nmrN	~+~c7EFQSqk4./K89wE\dXWxXf&pb:̒6US2"WUez|:s˖/F$iS[EjKJmQ\.TپoE؄ \
]B&[[ү+#*JzŪ3WLM4v- #nn4U
xAg%-q{Yj O)LczoF'`Y#,x6"v[%]FWu%y:<Z'M \
Ӽ;})nvO9㺪Q;(_I-2kG? \
ݑY]R"m&vB3Y'^̷;3dyt6áM. \
fSP9qϛdCmoE<YTĶPKf1PK>;Gp \
atches/0004-WineD3D-Add-a-create-flag-for-addref-in-GetPrivateDa.patchUXqJqJ \
VkoH_qadIJ0h[xj4vmRmmǞ;=am#F#NSlkjnS7
 6c   iuMӥ! t {YF|;577͔k\wᏔu#@Tudlʈȝ \
pVGPY:פ7Qӛ eXy&5Q% ;Mϖ; \
nlI1lC ({

. !_v4!lGBa:tydњj"ziʁc<2'l9A~{\>
#pM`Sc{Kqm'o0hlqP(60HPw[d`<249OXC'I \
{;`ïklmL|grE|& _u ^ A0ٯ0nfX)I]pXn \
ig;2^bKTIQ	 Hk,MCՅ~g,ob-}2cnf  \
vvJ@5ӀnlOnMI \
*em=lxVʒQEY#ː$zo7215hO!IIoAkmUvkinUr1 \
-FT;ɒ(c]]BԅkN{|Oo{59-k240~il#O*>#m \
bKMR]JXFD:j9ߎ\Z)6AR	\l'1	S,}w{[ެf|_
 ˃zB$r=b&#=Vp) \
)jn0_M{,u0,~U5g1\- 0ڇBs \
8GL.BkVGt@5ab'Dʗ 	KrGeBs+oƅ *Ђ{) \
Uzdn\OŇ9f+<V(մ4xW$K<DEW>Pb(ʕ-oe,ځ*B۩+\R;ahr(J$bN.x,Q#r$ \
{,QҌFl_ р1^VKhaI)>\KQFf_L*X.>FLQis8mcS|sI(! \
Oi`+_wwl rq]'efCSUW#^'ǓtvlFxl:   t/nG4 \
"(?wtA{ĥ_`Qۥy,q8Gc%ӜP90r.2?2"ϺS H \
Rv䗤M6$?PKt \
PK>;Dpatches/0005-WineD3D-Handle-surface-pitch-with-a-behavior-flag.patchUXqJqJUaoF_1rl
 R#;!'Uxa{&j;kIJ6vgq5-2Hv2v{F׳^]E]`; \
iMMӥ1  uՏE|v G_$|"v<8QRIz؆ \
"f$iioi]ƼVCo <da4`lcx6<ְؚ<(? T% \
A4(ɮDxzP\/dyC j1n%̒ rx[ʲ}i K%	*`⪄) \
"W@Y$QP?Htw){:+Ua \
2jZ4řː$YK>zSוfVp)Ol=n9U|Feix}xLGا|4pF]:t9;Uk``Hk";Hd \
:OlXg1]8g2t1:k"kS!VJ#H1[Y= \
fy{3r|t3`-GE7,Kv \
@#Ka+̇}=v!P-xz7WlFu_&7ӯsqHFőOI'<&w%ɼsUvmYhP@pZt`Fb]kT/rW~*?J,y:Vg9-F<㩪(17=
 F>-*II=_!I1+'O \
p͞*ԸhJ6)c<I])&q2fI=V	f'XZQ%}w߇N+,ŏȧL`r@.4Ub}(g/`A \
>d)БT?Ά xzjhu,<Ź`ΆdT \
> gL28XȽrm@$L|gL~;
D=w&BBdP4:de+`?m(dG8d6f2"T)Yt)IPKgk \
PK>;Gpatches/0006-WineD3D-Add-a-create-flag-for-addref-in-G \
etPrivateDa.patchUXqJqJVkoH_q[ؼ!KS!EjSDUBcfcl6!UͣlZcϝ8s`
 NԺM۵[-ҥFөQu \
fn[]tP;k\\~MK~M7zsɢ>˕wN@ٖGŚ*&IXn7e \
t3=eۍs|{[U̺ك@z#Kpsp͒iqEV<HD!	Cdx
 	lG!b6<bbG#
aW@Ōh`p5RBqi$dp* \
}Ȝb:讣DOI`3,<FC#Uleo0ix0C*0IYqgk\%`#]=RЎkĮݪ[^(xF痬Fc \
gbDnf,6%:^'IG030xzaRT \
W%,5@v-P.FVMNnFh}P& skS/2  ?{,gE
MH`E-(W\)*
FϓSOt0GմiY
Q)OJ\>;Ԍچu_lpʶ*8jwJ
"Knp6Xͧ~f^j	n
k~pB*Q=̏9 TUuw~dp*$kF \
xFY;b*I^t6/́5 \
x{D[d$VM?Ddq+7=q108.v6e3<>'_ŀ"2h'l<e.~2Ƹ \
C"46]/]nәTx(kyqTU@ \
KEc7LI$j.Ui^e'g2-V4kЂ[P[﨨;p*]'>{
 qaMPp5Rk~i|U 
&,#߇ .BH#wXmlb)Y~ᎋ<݌lRH1μ0
wґHl|
CnjNBڑXއvq_X<﷗DZƍf \
kIbG!^Y3f7*IDxOu$%i4+R<S>uAlw܆4k]pvsgE \
'ͺڂECQr'_'=D嬋؁K.^G./xA\tκo1tUyBkr{ 
ކ84[*؎|Q5PKޘ2
PK>;Gpatches/0007-WineD3D-Set-the-POINTSIZE-render-state-in-d3d8-avoid.patchUXqJqJV]H}Wܧ \
hmۂ;$mn7Fv\Nv-ThL&3ه݊8u﹇aDohцB5kdmCmm6i&|# \
(J'@CQTa0C2P@i}IsĄP&[3omPNSv'
 >OAiU4iْ \
O=7@!>"qH`Uq$$	@V>دWju&Xk|%+z^b_0#m@
 ׀+B1"ƪSdX`ZUn/U$}3%/JBBUZ4Ԗ \
*lrJl$C-0=0sSYVl:jҔfr\{0ElBTĵrn$ی9εL \
^eJg~ d5M3T 8L*``ۖmUI |m#[~j\ȉ
&F|0Wd$k*oqzEGCoetnН{3I2TI~~Mf!ɖPpA|tsU(S& \
L_pNKX3\ MމwPŎ }@(};p[&W'
7PWok^_\ \
aiCgLK[}R?ײ؂^̅srUs)ɶr,|ôɻzO;/"# \
>gRe|q'jXgޝY)ztUrz|J?=N0K+-?9cjK?=qm#mg>AtZU6PK? \
> 
PK>;+patches/0008-WineD3D-Remove-dxVersion.patchUXqJq \
JXs7UI@2I#9u${Eqlgwo$}Q*@3=u#ۀli=mZD,KQl[BDQwt⹰ \
[%K a.j9j~ɽn	MS/GhOy)ZH.asyDd \
pDR_vD[_^ \
fgx]KD|G`s9hp`:NpaMԍfMןւzFnK|q(B^Oh۫ϸ?yfd \
"n[~B6Pv gg&6mɮ(*e;$cLNJZL␨Q8Ӷ,h4b \
M5lJ.VDAu:ԂeGhtuvǿc{ڊ\d0Crԗ\Y'KX(?S?8~<y>w{4\|bx5b{M^yxWB
 ^qA],烛aM$lcGxT{0BG/nޑ5beI^#v1 \
%vڽМɋxƯغ wnƼ#[)޾𝞑?%>%N-
Y$42-C(쨬_d۩O6/C>+e>xPcUHc!ܮ
wsPpqG7`9T?`9QGcrM5ߤID"
=_Hv.ΘvTgu2Uh{K Y0j`z宇G \
#}Ƥg)l6īƷ/C~;[;4 \
9!nHFWO6^wYn\q^EA[.mnA TGW2>%1쟒]`r \
}hl&i>s"\VϿm)tr:1^iU|لU!FF-^6+oF&`<خ0I9b8A$IiUEU \
#,rGߣمp[&%Rx`lW|i<ۄZ͊GYvl!o|ԏ9C_ck2ä~q3IYkT\]Ml:_"TޤФ \
B r.~HPOy,!R_HDM<jxב"FE6iہ;6;'`y>R3;B#ed6r:; \
C絍tֶ[L>6R0jF1#k_At@շ,iT?Uižx/o>m;p \
,$h[%|~~!'UBWWe}"+HYD1,;Z#MPe/W̹/	R郖c%HS"8a0x⎖abil;K:	GS'}*R
 0 Jwi,Yo\UrM&-GX5W]У
bxے'}v>p0Yezq#.9:d
x
HF`z~;uD֞lč$,HOf1!(Om^ NDzmNO3@
q"B4ZŎ>6gkuKL \
w,%@O0v8-*͘_%Y\$Q%h*I2s$+6G+rEsrߒd)o!J	ڝnؓcgka!ZRǰDĉUB>qBt)DʡGB\
 xJkBFƱdTwUJ;m/鏿诜5;PKL]zIPK>; \
Epatches/0009-DDraw-SetRenderTarget-does-not-update-the-viewport.patchUX \
qJqJY{sHOћ*mImj\.%$wݯ!,q.wW*z=/zm˶ٴZ=RorZ٘u
 +-˴ P$?%^8C迻Ϊwz7m}YRFC;t{B6,H	 =-(FDN@[
2S=wOV$|.L3:6w\oE	&ĵH =Hҷ9C}/
jZk-ŏǭ y"Fa1FKM8z% \
αEVIބN5K0XSi,p@ZKBDţ, Z*,ǶZw"0kei \
LlS՚vG6 T&Mj<.4{fG$(dp>*8oF
U)@u7R2MUMOF2յ>@HL$
`0prĆэ]({0zm \
Nm|'2`,{8!t+lʹNo&gIF%,C\OiY^Yѯ.??^a}M4ۑz77czʙq<{NNf>Oظ4P?k
                
*n0
ױQ.6GǡP/Kѱ?	|ۚk22 N:V gmޚuIL%Y:Ji@bc \
s,z2"SNrY8ѯE:(V}-$\.Az \
,x>hLbmH膃o*vgNpB70uzs<8⾣.Re<Q  \
"+?*"u:ZiV<rw=QUl_CH!孀Txv>JB>Ԭ)a%9g4Ɛx~ߍ"~PGZJ
 "q*k/D和Pv4Tӊ+\_~%>%Z  \
W7R1T(#``FCyЗ.yca F}ԒLv+ \
2p>^IW>4L]JR>e(f;I^9M_}tܿ#UɭxN++aV;:.Vlo_=F0;=k*i?̗d+wOjkR"tjyeɶBk9gÜF5 \
G|,+@B_$}.)-i"}X689Vs)0A܉yT*8b	,V_c1nk$J"Hȱ+V`֫uOySbU_Sw)} \
t^1 0_QX("ٍZ`~Q \
&}}fD"ݎ:bQ*rn]6P[*\'Pߤ[=W) Tyˏյe+ \
U+GEwzb0֖/VQC31rZm>F(#&6hm?ՊV`DtM}qQyzmiH^C<%AD>,m
  Mz{[Bt,p<\aCNRT,;6zmL|O[םNې{it{^N-#eƨm۲ܤewf[
 D\W 

QSM
\B`<4_d[VsD3?T-ʬ!ڇbXݸ>IےWZ}7Zo&Z|S<K΄"S
 ؒ"> gKA+yvIs׷(
T>kO;NRVm<XDD!cn;v1ކTl1%fzb+kF]=*WeR$1cm
 čh>&8ZOK9Q_]sk[f[Duzv۩Z3'mn0
FbzgnFWpl@WbYZbDZgC8@tױ}[>sΡxMPS(=rKOOr@P1GPkZP7PK \
PK >;@Apatches/UXqJqJPK$>;Bݞr<@6patches/.DS_StoreUXqJqJPK
 (>;	@A__MACOSX/UXqJqJPK
(>;@A=__MACOSX/patches/UXqJqJPK$>;ܑ \
(R@|__MACOSX/patches/._.DS_StoreUXqJqJPK>; \
f5@patches/0001-WineD3D-Fix-a-contraditing-comment.patchUX \
qJqJPK>;aF@patches/0002-WineD3D-Start-repla \
cing-dxVersion-with-create-flags.patchUXqJqJPK>;f1C \
@patches/0003-WineD3D-Add-a-flag-for-static-vertex-buffer-FVFs.patchUXqJqJPK>;t
 G@patches/0004-WineD3D-Add-a-create-flag-for-addref-in-GetPrivateDa \
.patchUXqJqJPK>;gk	D@Ipatches/0005-WineD3D-H \
andle-surface-pitch-with-a-behavior-flag.patchUXqJqJPK>;ޘ2 \
G@ patches/0006-WineD3D-Add-a-create-flag-for-addref-in-GetPrivateDa.patchUXqJqJPK>;? \
 G@&patches/0007-WineD3D-Set-the-POINTSIZE-render-state-in-d3d8- \
avoid.patchUXqJqJPK>;L]zI+@+patches/0008-WineD3D-Remove-dxVersion.patchUXqJqJPK>; \
E@2patches/0009-DDraw-SetRenderTarget-does-not-update-the-viewport.patchUXqJqJPK \
 <





[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic