[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: ole32/tests: guard ReleaseStgMedium with SUCCEEDED
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2009-09-29 13:29:19
Message-ID: 873a656frk.fsf () wine ! dyndns ! org
[Download RAW message or body]

<Joerg-Cyril.Hoehle@t-systems.com> writes:

> @@ -1401,7 +1405,7 @@ static void test_getdatahere(void)
>      hr = IDataObject_GetDataHere(get, &fmt, &med);
>      ok(hr == S_OK, "got %08x\n", hr);
>      ok(med.tymed == TYMED_HGLOBAL, "got %x\n", med.tymed);
> -    ReleaseStgMedium(&med);
> +    if(SUCCEEDED(hr)) ReleaseStgMedium(&med);

I don't think that's correct for the GetDataHere case, it's allocated by
the caller.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]