[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [1/4] ws2_32/tests: Resend: IPv6 tests for WSAAddressToStringA
From:       Juan Lang <juan.lang () gmail ! com>
Date:       2009-04-27 20:14:23
Message-ID: 3a768c550904271314h64983ce8m6f68bf11ed569812 () mail ! gmail ! com
[Download RAW message or body]

Hi Jeff, I just wanted to clarify one of Detlef's comments:

>> -    ok( len == sizeof( expect4 ), "Got size %d\n", len);
>> +    ok( len == sizeof( expect4 ), "Expected size to be %d, got %d\n",
>> sizeof( expect4 ), len);
>
> Do not use sizeof() in a test.

Using sizeof is okay, but printing the result of it is not, due to
compile warnings this will introduce on some platforms.  Basically,
omit this change from your patch.

Thanks,
--Juan



[prev in list] [next in list] [prev in thread] [next in thread]