[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    SHGetFileInfo flag SHGFI_USEFILEATTRIBUTES together with SHGFI_PIDL
From:       Petr Sumbera <Petr.Sumbera () Sun ! COM>
Date:       2009-01-30 16:42:47
Message-ID: 49832E07.8040404 () sun ! com
[Download RAW message or body]

Hi All,

What is story behind following commit? This seems to broke Zoner Photo 
Studio (tested on OpenSolaris). According to some documentation 
combination of these flags is not allowed..

http://source.winehq.org/git/wine.git/?a=blobdiff;f=dlls/shell32/shell32_main.c;h=78a2 \
d578cf28947451a8d8c2819f18f4e7cb2930;hp=a0d3fe720b5504e9d9e1fb652a67acff2ca99bbb;hb=cf \
164785afac461a84e23d1e370205c28de73e0a;hpb=a971489dd075e5c39c26aa958b1f3683a1f70b95

--- a/dlls/shell32/shell32_main.c
+++ b/dlls/shell32/shell32_main.c
@@ -350,10 +350,6 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD 
dwFileAttributes,
            (flags & SHGFI_PIDL)? "pidl" : debugstr_w(path), 
dwFileAttributes,
            psfi, psfi->dwAttributes, sizeofpsfi, flags);

-    if ( (flags & SHGFI_USEFILEATTRIBUTES) &&
-         (flags & (SHGFI_ATTRIBUTES|SHGFI_EXETYPE|SHGFI_PIDL)))
-        return FALSE;
-
      /* windows initializes these values regardless of the flags */
      if (psfi != NULL)
      {

---

Petr


[prev in list] [next in list] [prev in thread] [next in thread]