[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: comctl32: Fix propsheet size calculation (resent)
From:       Vitaliy Margolen <wine-devel () kievinfo ! com>
Date:       2009-01-30 15:45:34
Message-ID: 4983209E.3070801 () kievinfo ! com
[Download RAW message or body]

Alexandre Julliard wrote:
> Vitaliy Margolen <wine-devel@kievinfo.com> writes:
> 
>> Alexandre Julliard wrote:
>>> Vitaliy <vitaliy@kievinfo.com> writes:
>>>
>>>> +  /* Get non-client size */
>>>> +  if (!psInfo->isModeless)
>>>> +  {
>>>> +    RECT rc1;
>>>> +
>>>> +    GetWindowRect(hwndDlg, &rc);
>>>> +    GetClientRect(hwndDlg, &rc1);
>>>> +    tabOffsetX = rc.right  - rc.left - (rc1.right  - rc.left);
>>>> +    tabOffsetY = rc.bottom - rc.top  - (rc1.bottom - rc.top);
>>> That doesn't make sense. What are you trying to compute here?
>>>
>> The size of non-client area - window borders and the title.
> 
> Even after fixing the typos it doesn't really make sense, especially
> with names like tabOffsetX. You probably want AdjustWindowRect or
> something like that.
> 
Oh, indeed. I will resubmit using AdjustWindowRect(). Thanks.

Vitaliy.


[prev in list] [next in list] [prev in thread] [next in thread]