[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: ole32: Add Co*InitializeSpy functions
From:       Maarten Lankhorst <maarten () codeweavers ! com>
Date:       2008-11-27 10:56:54
Message-ID: 492E7CF6.1030700 () codeweavers ! com
[Download RAW message or body]

Hi Rob,

Rob Shearman schreef:
> 2008/11/26 Maarten Lankhorst <maarten@codeweavers.com>:
>   
>> +
>> +HRESULT WINAPI CoRevokeInitializeSpy(ULARGE_INTEGER cookie)
>> +{
>> +    struct oletls *info = COM_CurrentInfo();
>> +    TRACE("(%s)\n", wine_dbgstr_longlong(cookie.QuadPart));
>> +
>> +    if (!info || !info->spy || cookie.QuadPart != (DWORD_PTR)info->spy)
>> +        return E_INVALIDARG;
>> +
>> +    IUnknown_Release(info->spy);
>> +    return S_OK;
>> +}
>>     
>
> No function documentation and you forget to clear info->spy before returning.
>   
I sent a patch that fixes that, and also releases it on TlsDestroy.

Cheers,
Maarten.



[prev in list] [next in list] [prev in thread] [next in thread]