[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: imm32: Add some really basic tests for ImmSetCompositionString().
From:       "Andrew Riedi" <andrewriedi () gmail ! com>
Date:       2008-11-27 6:24:45
Message-ID: 689de9370811262224j61a3974fvf2fa5b7bd5e99db2 () mail ! gmail ! com
[Download RAW message or body]

On Wed, Nov 26, 2008 at 10:06 PM, Dmitry Timoshkov
<dmitry@codeweavers.com> wrote:
> "Andrew Riedi" <andrewriedi@gmail.com> wrote:
>
>> +static int test_ImmSetCompositionString(void)
>
> It's a usual practice to have the test cases return 'void',
> especially if you don't use the return value.
>
>> +{
>> +    HIMC imc;
>> +    BOOL ret;
>> +    DWORD error;
>> +
>> +    imc = ImmGetContext(hwnd);
>
> First thing to test is the return value of ImmGetContext() and report
> last error in the case of a failure.
>
> --
> Dmitry.
>

Yeah, I was going to make it return void.  My plan was to just send
that patch in with an unused return value to match the style of the
rest of the file, then send a second patch later to make them all
void.

I agree I should check the return of ImmGetContext().

Thanks for looking over the patch.

-- 
Andrew Riedi


[prev in list] [next in list] [prev in thread] [next in thread]